917617 - Simulator start button UI tweaks

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Jeff pointed out that the Simulator start button is not very clear as a "Launch" button since it is gray, and displays the internal name of the add-on without an action verb in front of it.

We should use the blue color like "Connect" etc., and use a pretty name for the add-on if possible.

Comment 1

[Paul Rouget [:paul]]

We should add "Start: ", exactly like in the adb helper connection section ("Connect to:").

Comment 2

[Paul Rouget [:paul]]

(not critical for 26)

Comment 3

[i]

Attachment: Bug-917617-initial-work-screenshot.png

Comment 4

[i]

Attachment: Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch

Comment 5

[i]

Hi Paul

I've done some initial work on this bug,
but not quite sure if it's what you want.

Please take a look.

Comment 6

[Paul Rouget [:paul]]

Comment on attachment 820397 [details] [diff] [review]
Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch

Just rename startThisSimulator to startSimulator, and then I think we can land that :)

Thanks!

Comment 7

[i]

There's already startSimulator been defined:
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/app-manager.dtd#45

But seems unused:
http://mxr.mozilla.org/mozilla-central/search?string=connection.startSimulator&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozilla-central

Did you mean ?
<!ENTITY connection.startSimulator "Start Simulator">  ==>  <!ENTITY connection.startSimulator "Start:">

(In reply to Paul Rouget [:paul] from comment #6)
> Comment on attachment 820397 [details] [diff] [review]
> Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch
> 
> Just rename startThisSimulator to startSimulator, and then I think we can
> land that :)
> 
> Thanks!

Comment 8

[taj]

I would like to work on this bug, can you assign it to me.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to taj from comment #8)
> I would like to work on this bug, can you assign it to me.

Taj, this bug already has a patch and is nearly done.  Check out the good first bug list for other ones to pick from:

https://wiki.mozilla.org/DevTools/GetInvolved#Mentored_and_Good_First_Bugs

Comment 10

[i]

Attachment: Bug-917617-Start-Simulator-in-use.png

Comment 11

[i]

(In reply to i from comment #7)
> There's already startSimulator been defined:
> http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/
> browser/devtools/app-manager.dtd#45
> 
> But seems unused:
> http://mxr.mozilla.org/mozilla-central/search?string=connection.
> startSimulator&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozill
> a-central
> 
> Did you mean ?
> <!ENTITY connection.startSimulator "Start Simulator">  ==>  <!ENTITY
> connection.startSimulator "Start:">
> 
> (In reply to Paul Rouget [:paul] from comment #6)
> > Comment on attachment 820397 [details] [diff] [review]
> > Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch
> > 
> > Just rename startThisSimulator to startSimulator, and then I think we can
> > land that :)
> > 
> > Thanks!

Oh I was wrong about this,
actually connection.startSimulator was defined AND in use:

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/app-manager/content/connection-footer.xhtml#54
https://bug917617.bugzilla.mozilla.org/attachment.cgi?id=821416

Comment 12

[Paul Rouget [:paul]]

(In reply to i from comment #11)
> (In reply to i from comment #7)
> > There's already startSimulator been defined:
> > http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/
> > browser/devtools/app-manager.dtd#45
> > 
> > But seems unused:
> > http://mxr.mozilla.org/mozilla-central/search?string=connection.
> > startSimulator&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=mozill
> > a-central
> > 
> > Did you mean ?
> > <!ENTITY connection.startSimulator "Start Simulator">  ==>  <!ENTITY
> > connection.startSimulator "Start:">
> > 
> > (In reply to Paul Rouget [:paul] from comment #6)
> > > Comment on attachment 820397 [details] [diff] [review]
> > > Bug-917617-Simulator-start-button-UI-tweaks-initial-work.patch
> > > 
> > > Just rename startThisSimulator to startSimulator, and then I think we can
> > > land that :)
> > > 
> > > Thanks!
> 
> Oh I was wrong about this,
> actually connection.startSimulator was defined AND in use:
> 
> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/app-manager/
> content/connection-footer.xhtml#54
> https://bug917617.bugzilla.mozilla.org/attachment.cgi?id=821416

Good catch. So I guess startThisSimulator is good.

Comment 13

[Paul Rouget [:paul]]

Well… maybe not. Let's call that: `startRegisteredSimulator`.

Comment 14

[i]

(In reply to Paul Rouget [:paul] from comment #13)
> Well… maybe not. Let's call that: `startRegisteredSimulator`.

Good ideal :)

Comment 15

[i]

Attachment: Bug-917617-Simulator-start-button-UI-tweaks.patch

Comment 16

[Paul Rouget [:paul]]

Thank you Li!

Comment 17

[i]

(In reply to Paul Rouget [:paul] from comment #16)
> Thank you Li!

:)

Comment 18

[Ed Morley [:emorley]]

Thank you for the patch! :-)

https://hg.mozilla.org/integration/fx-team/rev/5615aa677b90

Comment 19

[i]

(In reply to Ed Morley [:edmorley UTC+1] from comment #18)
> Thank you for the patch! :-)
> 
> https://hg.mozilla.org/integration/fx-team/rev/5615aa677b90

:)

Comment 20

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5615aa677b90